Skip to content

Require non-null user and container in UserSchemas#6413

Merged
labkey-adam merged 3 commits intodevelopfrom
fb_user_schema
Mar 7, 2025
Merged

Require non-null user and container in UserSchemas#6413
labkey-adam merged 3 commits intodevelopfrom
fb_user_schema

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Mar 4, 2025

Rationale

A UserSchema with a null User or Container seems less useful. Throw if either are null at construction time.

Related Pull Requests

@labkey-adam
Copy link
Contributor Author

BVTs, etc. all green except for known, unrelated failures (see above).

Daily postgres all green except for known, unrelated failures: https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyPostgres_2/3407932

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also annotate the variables and getters as @NotNull?

@labkey-adam
Copy link
Contributor Author

Can we also annotate the variables and getters as @NotNull?

I think I have the ability to do that. Of course, there are 140 user schemas, so hard to know where to stop. I chose to annotate 6 - 7 "top-level" user schemas.

@labkey-jeckels
Copy link
Contributor

Can we also annotate the variables and getters as @NotNull?

I think I have the ability to do that. Of course, there are 140 user schemas, so hard to know where to stop. I chose to annotate 6 - 7 "top-level" user schemas.

I was just thinking within this class, but nice to begin to propagate out to subclasses

@labkey-adam labkey-adam merged commit 178fc36 into develop Mar 7, 2025
4 checks passed
@labkey-adam labkey-adam deleted the fb_user_schema branch March 7, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants